Define IndexOptions
in terms of mongodb.IndexOptions
#10563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current
IndexOptions
definition is missing some mongo-allowed properties, likepartialFilterExpression
. Since mongoose simply passes the value along (after handling the addedexpires
property), the type should be defined in the same way: as a simple extension to the mongoIndexOptions
type.Examples
This allows the following to work properly (in Typescript)