Enhance docs section linking #10779
Merged
Enhance docs section linking #10779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this fix #10652 @IslandRhythms ? |
|
Request review from Valeri. The sub section linking has a PR that fixes it. I don't know if he merged it already. |
|
Ah, I tried to look if anything was started and could not find it can you link it ? Also I cannot request a review myself, can you do it please? |
|
Ah! Well sorry I have undone a bit what you did haha, I wondered why I could not reproduce the issue. At first I just wanted to extend the "link icon" range's hover but got carried away. |
…ctions Followed by a commit which will remove as much as possible "manual" links. Using marked's built-in slugify function ensures the links would not be broken. Manual links are still supported, e.g. <h3 id="order"><a href="#order">Save/Validate Hooks</a></h3> However note that this syntax doesn't work (didn't work previously either) ### [Save/Validate Hooks](#order) Also makes the CSS better: * You can hover any part of the link + the "hidden" side where the icon appears * Handles h4
saveman71
force-pushed
the
fix-doc-section-linking
branch
from
cc60bc1
to
1f4e1d0
Compare
|
Rebased and fixed merge conflict |
vkarpov15
approved these changes
Oct 5, 2021
vkarpov15
added
the
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using marked's built-in slugify function ensures the links would not be broken.
Manual links are still supported, e.g.
However note that this syntax doesn't work (didn't work previously either)
Also makes the CSS better:
Removes as much as possible "manual" links, but some remain (mostly HTML ones I believe, didn't want to check each one that it wouldn't break a link)