Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gh-10875] Use stream destroy method on close to prevent emit 'close'… #10878

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

iovanom
Copy link
Contributor

@iovanom iovanom commented Oct 13, 2021

… event twice

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory.

If you're making a change to documentation, do not modify a .html file directly. Instead find the corresponding .pug file or test case in the test/docs directory.

Summary

These changes fix the issue with twice emitted 'close' events.
#10876

Examples

@IslandRhythms IslandRhythms linked an issue Oct 13, 2021 that may be closed by this pull request
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@vkarpov15 vkarpov15 added this to the 6.0.11 milestone Oct 14, 2021
@vkarpov15 vkarpov15 merged commit e7a932e into Automattic:master Oct 14, 2021
@iovanom
Copy link
Contributor Author

iovanom commented Oct 15, 2021

@vkarpov15 Could you add this fix also in version 5? I'm using version 5 in prod for my project and I need this fix.

@simllll
Copy link
Contributor

simllll commented Oct 19, 2021

This PR breaks my setup, some of my streams now never ends.. some of them do though.

my simple setup is like this:
image

the finish event is in 80% not fired.

@simllll simllll mentioned this pull request Oct 19, 2021
@iovanom
Copy link
Contributor Author

iovanom commented Oct 19, 2021

This PR breaks my setup, some of my streams now never ends.. some of them do though.

my simple setup is like this: image

the finish event is in 80% not fired.

what node version do you use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor 'close' event emitted twice
3 participants