Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for all flags in a regex deepequal #11242

Merged
merged 2 commits into from
Jan 27, 2022
Merged

check for all flags in a regex deepequal #11242

merged 2 commits into from
Jan 27, 2022

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Jan 18, 2022

This PR modifies the deepEqual check in mongoose. It checks a regex for all 6 flags of a Regex.

As it is more strict, it could be breaking(?)

@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Jan 18, 2022

The failing of the test seems to be not related to the change.

vkarpov15
vkarpov15 requested changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I'm ok to merge this, just looks like there might still be one flag missing. I think this is a fairly clear bug.

lib/utils.js Outdated Show resolved Hide resolved
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👏
Appreciate all the good work 👍

vkarpov15
vkarpov15 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.1.9 milestone Jan 27, 2022
@vkarpov15 vkarpov15 merged commit 5ab6550 into Automattic:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uzlopak @vkarpov15 @AbdelrahmanHafez