Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(connection&base): add support for continueOnError #11266

Merged
merged 14 commits into from
Feb 1, 2022

Conversation

AbdelrahmanHafez
Copy link
Collaborator

fixes #11039

@AbdelrahmanHafez AbdelrahmanHafez marked this pull request as ready for review January 27, 2022 23:17
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments, but 👍 overall

index.d.ts Outdated Show resolved Hide resolved
lib/connection.js Show resolved Hide resolved
lib/connection.js Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 changed the base branch from master to 6.2 February 1, 2022 17:24
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 merging this into 6.2

@vkarpov15 vkarpov15 merged commit 6f8accb into Automattic:6.2 Feb 1, 2022
@AbdelrahmanHafez AbdelrahmanHafez deleted the gh-11039 branch February 1, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants