Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add back nyc #11297

Merged
merged 1 commit into from
Jan 30, 2022
Merged

chore: add back nyc #11297

merged 1 commit into from
Jan 30, 2022

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Jan 30, 2022

This PR adds back nyc to mongoose. Maybe the first step to also use a github action for test coverage?

vkarpov15
vkarpov15 approved these changes Jan 30, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 we would like to add test coverage, but haven't gotten around to it yet.

@vkarpov15 vkarpov15 added this to the 6.1.10 milestone Jan 30, 2022
@vkarpov15 vkarpov15 merged commit 1a6eca8 into Automattic:master Jan 30, 2022
@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Jan 30, 2022

@vkarpov15
There are some good 3rd party tools for coverage like coveralls.io . But I can't activate them because I am not the maintainer. If you could activate it, I could provide the GitHub action later.

@vkarpov15 vkarpov15 modified the milestones: 6.1.10, 6.1.9 Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uzlopak @vkarpov15