Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr: hasDollarKeys #11401

Merged
merged 1 commit into from
Feb 17, 2022
Merged

impr: hasDollarKeys #11401

merged 1 commit into from
Feb 17, 2022

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Feb 15, 2022 •
edited

Small refactoring of hasDollarKeys

  • added a name to the function
  • the typecheck now uses !== instead of !=, as we just switched the conditions in the if-clause. So no implicit conversion of nullish values.
  • uses direct character comparison instead of startsWith.

AbdelrahmanHafez
AbdelrahmanHafez approved these changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

vkarpov15
vkarpov15 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 633f2d4 into Automattic:master Feb 17, 2022
@vkarpov15 vkarpov15 added this to the 6.2.3 milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Uzlopak @vkarpov15 @AbdelrahmanHafez