Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken link rawResult (findAndModify) #11459

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

chhiring90
Copy link
Contributor

Fix broken link findAndModify from (node-mongodb-native 2.0 ) to (node-mongodb-native 3.0).

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory.

If you're making a change to documentation, do not modify a .html file directly. Instead find the corresponding .pug file or test case in the test/docs directory.

Summary

Examples

Fix broken link findAndModify from (node-mongodb-native 2.0 ) to (node-mongodb-native 3.0).
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @chhiring90
Congratulations on your first PR 🎉

I can see that we're using the native driver with version 4.3, shouldn't we be using 4.3 modifyResult instead?
https://mongodb.github.io/node-mongodb-native/4.3/interfaces/ModifyResult.html

Updated link findAndModify from version(3.0) to version(4.3).
@chhiring90
Copy link
Contributor Author

Thank you very much. I appreciate it.
I've done the changes as per your suggestion. My apologies for updating depreciated version.
Let me know your advice on it.

@AbdelrahmanHafez AbdelrahmanHafez added this to the 6.2.5 milestone Mar 1, 2022
@AbdelrahmanHafez
Copy link
Collaborator

Thanks 👍

@AbdelrahmanHafez AbdelrahmanHafez merged commit b3f37e9 into Automattic:master Mar 1, 2022
@chhiring90
Copy link
Contributor Author

You're welcome 😊.

@chhiring90 chhiring90 deleted the patch-1 branch March 1, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants