Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract and refactor schemaoptions #11484

Merged

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Mar 5, 2022

This is reviewable

Extracted SchemaOptions

removed emitIndexErrors
change typings for excludeIndexes and skipVersioning from any to the types how they are documented and how they are expected by the code.

* You can suppress the warning by setting { supressReservedKeysWarning: true } schema options. Keep in mind that this
* can break plugins that rely on these reserved names.
*/
supressReservedKeysWarning?: boolean
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this is a typo. Should have been "suppress[...]" and not "supress[...]".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that's something we should change in Mongoose 7. I opened up #11495 to track that

@Uzlopak Uzlopak changed the title Chore extract refactor schemaoptions chore: extract and refactor schemaoptions Mar 6, 2022
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.2.5 milestone Mar 7, 2022
@vkarpov15 vkarpov15 merged commit da0f4bd into Automattic:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants