Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): upgrade highlight.js from 9.18.3 to 11.5.0 #11579

Merged
merged 2 commits into from
Apr 3, 2022

Conversation

AbdelrahmanHafez
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez commented Mar 25, 2022

This PR fixes the breaking changes from upgrading to v10 and v11.

The only downside is IE11 support being dropped in v10 which I think is fine.

I also tested the rendering manually on my machine, and the docs highlighting is identical to the one in production.

dependabot bot and others added 2 commits March 25, 2022 01:36
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.18.3 to 11.5.0.
- [Release notes](https://github.com/highlightjs/highlight.js/releases)
- [Changelog](https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md)
- [Commits](https://github.com/highlightjs/highlight.js/commits/11.5.0)

---
updated-dependencies:
- dependency-name: highlight.js
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@AbdelrahmanHafez AbdelrahmanHafez changed the title chroe(deps-dev): upgrade highlight.js from 9.18.3 to 11.5.0 chore(deps-dev): upgrade highlight.js from 9.18.3 to 11.5.0 Mar 25, 2022
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll manually go through the code highlighting locally as well just to be sure.

@vkarpov15 vkarpov15 added this to the 6.2.10 milestone Apr 3, 2022
@vkarpov15 vkarpov15 merged commit 7f268bb into master Apr 3, 2022
@vkarpov15 vkarpov15 deleted the update-highlight branch April 3, 2022 16:37
vkarpov15 added a commit that referenced this pull request Apr 3, 2022
vkarpov15 added a commit that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants