Bug/types/update query

[AbdelrahmanHafez]

Currently, we can do the following in JavaScript:

const userSchema = new Schema({ name: String });
const User = mongoose.model('User', userSchema);

await User.updateOne({}, { name: 'Sam' });

But TypeScript doesn't know that the second parameter to updateOne can take name as a top level property.
It would, however, understand the types if we use $set:

// provides inteliisense support
await User.updateOne({}, { $set: { name: 'Sam' } });

// does not provide intellisense support
await User.updateOne({}, { name: 'Sam' });

I managed to make it read the properties from the interface, but another bug seems to be that it converts all types to any instead of the type defined on the schema.

[Uzlopak]

I think the reason is the Union Type with AnyObject resulting in a Type Widening. I would usually try with Omit<AnyObject, keyof T & _UpdateQuery<_UpdateQueryDef>> instead of just using AnyObjecy.

Suggested change

	export type UpdateQuery<T> = Partial<T> & _UpdateQuery<_UpdateQueryDef<T>> & AnyObject;
	export type UpdateQuery<T> = Partial<T> & _UpdateQuery<_UpdateQueryDef<T>> & Omit<AnyObject, keyof T & _UpdateQuery<_UpdateQueryDef<T>>>;

Didn't test it, just wrote it with my mobile.

Also look into the populate typing PR. @mohammad0-0ahmad used a different notation to achieve the correct typings

[mohammad0-0ahmad]

Or maybe the following, if update query should accept any type:
@vkarpov15 what do u think about that ?

export type UpdateQuery<T> = _UpdateQuery<_UpdateQueryDef<T>> & (T | AnyObject);

[vkarpov15]

@mohammad0-0ahmad that approach works for me, as long as it is & (Partial<T> | AnyObject)

[vkarpov15]

Thanks. Overall, I think this approach works and is a neat improvement for intellisense. I'll try out @mohammad0-0ahmad 's suggestion after merging.

[vkarpov15]

@mohammad0-0ahmad that approach works for me, as long as it is & (Partial<T> | AnyObject)

[vkarpov15]

Actually, I didn't notice that this is causing test failures, sorry. I'm going to have to revert and we'll have to consider how we can do this without breaking our tests.