Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarified docs on populate #11768

Merged
merged 2 commits into from
May 5, 2022
Merged

clarified docs on populate #11768

merged 2 commits into from
May 5, 2022

Conversation

IslandRhythms
Copy link
Collaborator

@IslandRhythms IslandRhythms commented May 4, 2022 •
edited by AbdelrahmanHafez

fixes #11621

@IslandRhythms IslandRhythms self-assigned this May 4, 2022
AbdelrahmanHafez
AbdelrahmanHafez reviewed May 4, 2022
View reviewed changes
lib/query.js Outdated Show resolved Hide resolved
vkarpov15
vkarpov15 requested changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Array<String> instead of [String], otherwise 👍

@Uzlopak @AbdelrahmanHafez
Update lib/query.js
777ce80 
Co-authored-by: Hafez <a.hafez852@gmail.com>
@Uzlopak Uzlopak requested a review from vkarpov15 May 5, 2022 11:30
@Uzlopak Uzlopak merged commit dff4073 into master May 5, 2022
@Uzlopak Uzlopak deleted the gh-11621 branch May 5, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak left review comments

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez left review comments

@vkarpov15 vkarpov15 Awaiting requested review from vkarpov15

Assignees

@IslandRhythms IslandRhythms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Query.populate docs do not include using an array of strings for the path param
4 participants
@IslandRhythms @vkarpov15 @Uzlopak @AbdelrahmanHafez