Feature/ts lean missing doc fixes #11761 without killing LeanDocument #11769
Conversation
types/document.d.ts
Outdated
| @@ -225,7 +225,7 @@ declare module 'mongoose' { | |||
| toJSON<T = DocType>(options: ToObjectOptions & { flattenMaps: false }): LeanDocument<T>; | |||
|
|
|||
| /** Converts this document into a plain-old JavaScript object ([POJO](https://masteringjs.io/tutorials/fundamentals/pojo)). */ | |||
| toObject<T = DocType>(options?: ToObjectOptions): LeanDocument<T>; | |||
| toObject<T = DocType>(options?: ToObjectOptions): Require_id<LeanDocument<T>>; | |||
There was a problem hiding this comment.
In the interest of backwards compat, why not make this just toObject<T = LeanDocument<DocType>> and return Require_id<T>? That should allow people to bypass going through LeanDocument, which seems to be causing part of the problem.
There was a problem hiding this comment.
Definitely an option; by doing that you will not be converting any mongoose.Types.Array types to real javascript arrays and any embedded subdocuments won't get converted to POJOs.
There was a problem hiding this comment.
So I guess that's my way of saying "it's up to you", but also answering "why not" =]
|
@vkarpov15 I added one more quick change -- .lean was not actually applying LeanDocument, which resulted in lean not actually propagating and fixing things like the arrays, subdocuments, etc. |
Summary
Per #11761
.toObjectdoesn't add_idto the document if it is missing; this fixes that.Examples
See unit tests in the code