Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codeql sec warnings #11817

Merged
merged 4 commits into from
May 28, 2022
Merged

Fix codeql sec warnings #11817

merged 4 commits into from
May 28, 2022

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented May 18, 2022

I checked the codeql warnings. We had three false positives, which i dismissed. I hope this will fix the valid positive security warnings.

vkarpov15
vkarpov15 reviewed May 27, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion. Otherwise LGTM 👍

lib/helpers/path/setDottedPath.js Outdated Show resolved Hide resolved
vkarpov15
vkarpov15 approved these changes May 28, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 6.3.5 milestone May 28, 2022
@vkarpov15 vkarpov15 merged commit 051726c into Automattic:master May 28, 2022
@Uzlopak Uzlopak deleted the fix-codeql-sec-warnings branch May 28, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uzlopak @vkarpov15