fix typo: indezes => indeces #11953
fix typo: indezes => indeces #11953
Conversation
indezes is probably German, we could also use indexes but indeces is more comoon
AbdelrahmanHafez
requested review from
vkarpov15 and
Uzlopak
and removed request for
vkarpov15
AbdelrahmanHafez
added
the
typescript
| @@ -8,7 +8,7 @@ | |||
| /// <reference path="./expressions.d.ts" /> | |||
| /// <reference path="./helpers.d.ts" /> | |||
| /// <reference path="./middlewares.d.ts" /> | |||
| /// <reference path="./indizes.d.ts" /> | |||
| /// <reference path="./indeces.d.ts" /> | |||
There was a problem hiding this comment.
Minor nitpick: this is still a typo, the correct spelling is "indices". However, we typically use "indexes" as the plural form of "index". Similar reasoning to the "schemas" vs "schemata" debate: "indexes" is acceptable according to Oxford English Dictionary, and should be easier for non-native English speakers to understand because it doesn't use a special pluralization rule.
There was a problem hiding this comment.
Should @AbdelrahmanHafez change it to indexes?
There was a problem hiding this comment.
@vkarpov15
Good catch 🤦
I considered both options and considered that indexes is easier for non-native English speakers, but a quick Google search says that indices is actually more common than indexes. But yeah, I can see that even though I knew indices, I don't know how to spell it properly.
We can go for indexes which is a little bit less acceptable, but expectable.
There was a problem hiding this comment.
Another point in favor of "indexes" is that the MongoDB documentation calls them "indexes" rather than "indices": https://www.mongodb.com/docs/manual/indexes/ . I think we should err on the side of consistency with the MongoDB docs on this front
fix(types): fix typo for `indexes` re #11953
No description provided.