New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update isDirectModified typing #12290

Merged

AbdelrahmanHafez merged 1 commit into Automattic:master from gabrielDonnantuoni:patch-2

Aug 17, 2022

Contributor

gabrielDonnantuoni commented Aug 17, 2022

As the current code already implements it, just a type declaration fix:

Change arg type from string to string | Array<string>.


          fix: Update isDirectModified typing

4336d1c

Change arg type from string to string | Array<string>.

AbdelrahmanHafez added this to the 6.5.3 milestone

AbdelrahmanHafez added the typescript label

AbdelrahmanHafez approved these changes

View reviewed changes

Collaborator

AbdelrahmanHafez left a comment

LGTM, thanks 👍

AbdelrahmanHafez merged commit fe1ad41 into Automattic:master

AbdelrahmanHafez added a commit that referenced this pull request


          test(types): add test re #12290

adec3de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment