Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language_override option mention #12310

Merged
merged 1 commit into from
Aug 23, 2022
Merged

language_override option mention #12310

merged 1 commit into from
Aug 23, 2022

Conversation

IslandRhythms
Copy link
Collaborator

No description provided.

AbdelrahmanHafez
AbdelrahmanHafez requested changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @IslandRhythms

Can you please add TS types in types\indexes.d.ts and the tests to verify that it's working correctly?

vkarpov15
vkarpov15 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't necessary to add language_override to indexes.d.ts because MongoDB driver already defines language_override here:

https://github.com/mongodb/node-mongodb-native/blob/846365a5ef58acb53480fbd5a7e0e83cbfed2a3e/src/operations/indexes.ts#L96-L118

@IslandRhythms IslandRhythms self-assigned this Aug 23, 2022
@vkarpov15 vkarpov15 added this to the 6.5.3 milestone Aug 23, 2022
@vkarpov15 vkarpov15 merged commit 8c0800a into master Aug 23, 2022
@vkarpov15 vkarpov15 deleted the language-override-docs branch August 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez requested changes

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees

@IslandRhythms IslandRhythms

Labels
None yet
Projects
None yet
Milestone
6.5.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IslandRhythms @vkarpov15 @AbdelrahmanHafez