Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dox #12403

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Update dox #12403

merged 3 commits into from
Sep 7, 2022

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Sep 7, 2022

Summary

This PR updates dox to 1.0.0 which (finally) includes a update of jsdoctypeparser and so fixes some of the audit problems

also includes a update so that @inherits having a URL is handled like a @see

Note: this change does not include a change to api.pug, because that file does not include the Inherits section and is probably gone soon anyway

@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Sep 7, 2022
@Uzlopak
Copy link
Collaborator

Uzlopak commented Sep 7, 2022 •
edited

Maybe the chance to remove this too

mongoose/.github/dependabot.yml

Line 10 in 7ccaa47

- dependency-name: "dox"

@hasezoey
Copy link
Collaborator Author

hasezoey commented Sep 7, 2022

@Uzlopak done with 3000758

vkarpov15
vkarpov15 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this locally and works great. Thanks so much @hasezoey 👍

@vkarpov15 vkarpov15 added this to the 6.5.5 milestone Sep 7, 2022
@vkarpov15 vkarpov15 merged commit 001dda3 into Automattic:master Sep 7, 2022
@hasezoey hasezoey deleted the updateDox branch September 8, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
6.5.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hasezoey @Uzlopak @vkarpov15 @AbdelrahmanHafez