Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list all possible strings for schema.pre #12868

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

IslandRhythms
Copy link
Collaborator

No description provided.

docs/middleware.md Outdated Show resolved Hide resolved
@jdevries3133
Copy link

Hey folks, is it possible to extend an opportunity to @larasodjati to draft a PR for the issue she's identified here?

Lara is a student in an org I'm volunteering for and I'm hoping to sponsor / assist her to see this issue through to a merged PR.

Obviously totally understand if you want to close this out quickly, and @IslandRhythms, your work is definitely appreciated and I wouldn't want to step on your toes either. In any case, it would be great if we could open an opportunity for Lara to make her first open source contribution!

Thanks all!

@IslandRhythms
Copy link
Collaborator Author

I have no objection but I'll need to confirm with val if its ok.

@IslandRhythms
Copy link
Collaborator Author

IslandRhythms commented Jan 9, 2023

Val would rather I do it, sorry.

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15
Copy link
Collaborator

@jdevries3133 sorry we missed your post, this PR is already done. But I appreciate the offer. Please let me know if you want another light docs issue that your student can help out with.

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit 6d7f0e8 into master Jan 9, 2023
@vkarpov15 vkarpov15 added this to the 6.8.4 milestone Jan 9, 2023
@jdevries3133
Copy link

@jdevries3133 sorry we missed your post, this PR is already done. But I appreciate the offer. Please let me know if you want another light docs issue that your student can help out with.

No worries, totally understand. We'll definitely be on the lookout for another light docs issue, if you have a suggestion that would be much appreciated!

@hasezoey hasezoey deleted the IslandRhythms/middleware-strings branch May 19, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation should include a listing of all strings passable to .pre and .post
3 participants