Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(typescript): add notes about virtual context to Mongoose 6 migration and TypeScript virtuals docs #12912

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #12806

Summary

Couple of quick notes in the docs re: #12806. Mostly make a note of a potentially breaking change, and also highlight the virtual<MyTypeHere> escape hatch for when types are not quite right.

Examples

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor spelling suggestion

docs/typescript/virtuals.md Outdated Show resolved Hide resolved
@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Jan 16, 2023
Co-authored-by: hasezoey <hasezoey@gmail.com>
@vkarpov15 vkarpov15 merged commit 92fcc58 into master Jan 17, 2023
@hasezoey hasezoey deleted the vkarpov15/gh-12806 branch January 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues when migrating from 5.12.3 to 6.8.0
2 participants