feature: add removeVirtual(path) function to schema
#12920
Conversation
lib/schema.js
Outdated
| if (this.virtuals[name] == null && !this.nested[name]) { | ||
| throw new MongooseError('Attempting to remove virtual path that does not exist.'); | ||
| } | ||
| if (this.nested[name]) { |
There was a problem hiding this comment.
Please add a test case that shows when this code path would be executed. Not sure when this would happen.
There was a problem hiding this comment.
This is my mistake. I thought that if a virtual for whatever reason was nested it would go there. Evidently, it seems that you can't nest a virtual as when I attempted to write a test to do so it was not registered in the schema anywhere.
lib/schema.js
Outdated
| function _deleteVirtualPath(schema, name) { | ||
| const virtuals = schema.virtuals; | ||
| if (virtuals[name]) delete virtuals[name]; | ||
| else throw new MongooseError('Attempting to delete a a virtaul path that does not exist'); // You should never see this message |
There was a problem hiding this comment.
Multiple typos in error message. Also what is with the comment?
There was a problem hiding this comment.
the removeVirtual() function is checking for that already. So for else block to execute, a user would have to be calling the _deleteVirtualPath function directly which would be circumventing the process.
There was a problem hiding this comment.
Ah ok, so the issue is that this check is completely unnecessary, as is the helper function. I removed both in af20f0e.
No description provided.