fix(connection): add stub implementation of doClose
to base connection class
#13157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12971
Summary
Quick detail that shouldn't affect any prod code. But #12971 does point out that our base connection class doesn't have a
doClose()
method, but callsthis.doClose()
. The built-in MongoDB driver layer does have adoClose()
, but there's no indication to anyone building a new driver that they need to implement that, and if you instantiate a new connection directly (which you shouldn't do) you'll get an error aboutdoClose()
not being a function.Examples