fix(document): apply setters on resulting value when calling Document.prototype.$inc() #13178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….prototype.$inc() Fix #13158
vkarpov15
requested review from
Uzlopak,
hasezoey,
AbdelrahmanHafez and
IslandRhythms
hasezoey
reviewed
Mar 16, 2023
hasezoey
reviewed
Mar 16, 2023
IslandRhythms
approved these changes
Mar 16, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13158
Summary
Document.prototype.$inc() doesn't call setters right now, which is a little strange given that
findOneAndUpdate()with$incdoes call setters.The biggest wrinkle here is that we're calling setters on the resulting value, not the value passed in to
$inc. So$inc('balance', 4)will call setters withbalance = 6 + 4ifbalancewas originally 6. I think this is slightly better because setters are often used for rounding, and we want to make sure devs that are using$inc()instead of+=don't run into unexpected binary floating point precision issues.Examples