Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): make creating top-level virtual underneath subdocument equivalent to creating virtual on the subdocument #13197

Merged
merged 3 commits into from
Mar 23, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13189
Re: #8210
Re: #8198

Summary

Apply the fix for #8198 to single nested subdocuments, as opposed to just arrays. That looks like it fixes #13189, which highlights the same underlying issue as #8210.

Examples

Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace lint issues but other than that LGTM

@vkarpov15 vkarpov15 merged commit 228e853 into master Mar 23, 2023
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-13189 branch March 23, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A population of virtual type in the nested path is not visible in toJSON.
3 participants