Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add version support and check version docs #13251

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Conversation

vkarpov15
Copy link
Collaborator

Fix #13193

Summary

Added a page explaining our support policy for Mongoose versions, including setting an EOL for Mongoose 5. On a related note, also added a page about how to check what Mongoose version you're using.

Examples

Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, but i think there are some things that still need to be changed

docs/source/index.js Show resolved Hide resolved
docs/layout.pug Show resolved Hide resolved
docs/check-version.md Outdated Show resolved Hide resolved
docs/check-version.md Outdated Show resolved Hide resolved
@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Apr 6, 2023
vkarpov15 and others added 3 commits April 6, 2023 13:44
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
docs/source/index.js Outdated Show resolved Hide resolved
@vkarpov15 vkarpov15 merged commit 87a9a7f into 6.x Apr 6, 2023
1 check passed
@vkarpov15 vkarpov15 added this to the 6.10.5 milestone Apr 6, 2023
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-13193 branch April 6, 2023 18:03
@@ -1,5 +1,8 @@
# Migrating from 4.x to 5.x

Please note: we plan to discontinue Mongoose 5 support on March 1, 2024.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'm not understanding correctly but from reading this it appears mongoose 5 is going to be supported longer than mongoose 6?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we're discontinuing support for Mongoose 5 on March 1, 2024. We don't have any plan to discontinue support for Mongoose 6 currently.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably because of
docs/version-support.md

We will continue to ship bug fixes to Mongoose 6 until August 24, 2023.

Copy link
Collaborator

@IslandRhythms IslandRhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment but otherwise LGTM

@alexbevi
Copy link
Contributor

@vkarpov15 is this intended to only be available on the 6.x branch of the docs? Seems it would be worth having in master as well for discoverability

@hasezoey
Copy link
Collaborator

@alexbevi mongoose currently works by merging the 6.x branch into master often, and this PR has already been merged into master, but the website only really updates if it is urgent or if a version is released (which is not done yet since 6.x merge)

@alexbevi
Copy link
Contributor

@hasezoey thanks for clarifying. Since this will be available "eventually" that's good enough for me.

@vkarpov15
Copy link
Collaborator Author

vkarpov15 commented Apr 19, 2023

@alexbevi just to confirm, these changes are on the 7.x docs now too: https://mongoosejs.com/docs/version-support.html . We regularly merge 6.x back into master.

@alexbevi
Copy link
Contributor

Thanks for keeping me posted @vkarpov15. It was a bit confusing why it wasn't there yet but @hasezoey cleared that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants