Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(typescript): highlight auto type inference for methods and statics, add info on using methods with generics #13696

Merged
merged 2 commits into from
Aug 3, 2023
Merged

docs(typescript): highlight auto type inference for methods and statics, add info on using methods with generics #13696

merged 2 commits into from
Aug 3, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #12942

Summary

Make statics and methods TypeScript section highlight the auto type inference approach first, and also add info on how to use generics for methods.

Examples

@vkarpov15
docs(typescript): highlight auto type inference for methods and stati…
cdfae32 
…cs, add info on using methods with generics

Fix #12942
AbdelrahmanHafez
AbdelrahmanHafez approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. 👍

hasezoey
hasezoey approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though there is one sentence which should probably be removed

docs/typescript/statics.md Show resolved Hide resolved
@hasezoey hasezoey added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Aug 3, 2023
@vkarpov15 vkarpov15 merged commit b1e0b7c into master Aug 3, 2023
2 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12942 branch August 3, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Property 'updateDescription' does not exist on type 'Document<unknown, any
3 participants
@vkarpov15 @hasezoey @AbdelrahmanHafez