fix(document): avoid flattening dotted paths in mixed path underneath nested path #14198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14178
Summary
This function call was introduced in 98150ac, but it isn't entirely clear why this
flattenObjectWithDottedPaths()
call is necessary. In fact, it is potentially harmful because it can unintentionally modify the document, as was the case in #14178. AllflattenObjectWithDottedPaths
does is flatten out all dotted paths in the nested path, which doesn't seem like correct behavior.Examples