fix(discriminator): handle reusing schema with embedded discriminators defined using Schema.prototype.discriminator #14202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14162
Summary
#14162 points out that if you reuse a schema that has embedded discriminators defined using
Schema.prototype.discriminator()
, you'll get an OverwriteModelError because Mongoose already applied discriminators to the schema type. This PR makes it so that applying discriminators to the same SchemaType twice is a no-op.Examples