Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about decimal ? #4759

Closed
YouriT opened this issue Dec 1, 2016 · 9 comments
Closed

What about decimal ? #4759

YouriT opened this issue Dec 1, 2016 · 9 comments
Milestone

Comments

@YouriT
Copy link

YouriT commented Dec 1, 2016

Decimal BSON type has been introduced in Mongo 3.4 therefore, it would be convenient that this type would be also available within mongoose.

For more informations => https://docs.mongodb.com/manual/tutorial/model-monetary-data/#numeric-decimal

I'm quickly checking how long it would take me and checking if I can put that on my roadmap

@YouriT
Copy link
Author

YouriT commented Dec 2, 2016

Some basic doc can be found here: http://mongodb.github.io/node-mongodb-native/2.2/tutorials/crud/

@hungchai
Copy link

hungchai commented Dec 3, 2016

Decimal Bson type is one of important feature in Mongo 3.4. Hope that available within mongoose as soon as possible. Thanks

@YouriT
Copy link
Author

YouriT commented Dec 3, 2016

Yup, let's see what the people here say :)

@vkarpov15 vkarpov15 added this to the 4.8 milestone Dec 4, 2016
@vkarpov15
Copy link
Collaborator

Yep definitely a major priority, will release soon 👍

@YouriT
Copy link
Author

YouriT commented Dec 4, 2016

@vkarpov15 wasn't expecting less from your side, always reactive! ⚡️

@marcelh-gh
Copy link

In the 5.0.8 docs I still just find Number as numeric type.

Does the fixed label assigned to this issue not mean that a decimal type was implemented?

@YouriT
Copy link
Author

YouriT commented Mar 6, 2018

@marcelh-gh yup it has been. You can check the above commit reference: 61d665c

Documentation doesn't seem up to date, I suggest you open a new issue about it.

Strangely it was in the previous docs.

@marcelh-gh
Copy link

@YouriT thanks a lot for the quick answer. Awesome!

@marcelh-gh
Copy link

@YouriT so, there is a Decimal128 type. What about integer/ long? I didn't find anything in the old docs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants