Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support screen #451

Merged
merged 6 commits into from Feb 28, 2020
Merged

Add support screen #451

merged 6 commits into from Feb 28, 2020

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Feb 27, 2020

All Submissions:

Changes proposed in this Pull Request:

A support form, which will submit a ticket to Zendesk.

image

How to test the changes in this Pull Request:

  1. observe that there is no "support" submenu item in Newspack menu in admin
  2. add necessary environment variables to wp-config.php:
define('NEWSPACK_SUPPORT_API_URL', 'https://my-super-support.zendesk.com/api/v2');
define('NEWSPACK_SUPPORT_EMAIL', 'support@site.com');
  1. observe that there is a "support" submenu item in Newspack menu in admin
  2. visit the support wizard, you should see a form
  3. fill in subject and message and submit the form
  4. a success message should greet you
  5. a ticket should appear in the Zendesk instance

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 27, 2020
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PHP code looks good and this works as intended. Good work! I'd hold off merging until we finish discussing, though. :)

@adekbadek adekbadek removed the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 28, 2020
Copy link
Contributor

@thomasguillot thomasguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've just added some tiny visual changes in 8e473ae

@thomasguillot thomasguillot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Design Review labels Feb 28, 2020
@adekbadek adekbadek merged commit c76cb72 into master Feb 28, 2020
@adekbadek adekbadek deleted the add/support-screen branch February 28, 2020 16:23
@adekbadek adekbadek mentioned this pull request Mar 3, 2020
6 tasks
matticbot pushed a commit that referenced this pull request Mar 3, 2020
# 1.0.0 (2020-03-03)

### Bug Fixes

* action card right region text align ([168c64d](168c64d))
* Better population of countries for ones with no states defined ([314d6a2](314d6a2))
* linting and formatting js ([#383](#383)) ([b4828c8](b4828c8))
* more reliable Site Kit connection check ([05a66f2](05a66f2))
* move author bio length setting inside togglegroup ([a374d96](a374d96))
* newspack logo in starter content ([#465](#465)) ([ace948e](ace948e))
* npm dev script ([4ec6fcb](4ec6fcb))
* plugins-screen script and stylesheet paths ([#445](#445)) ([fb98e3a](fb98e3a))
* remove calc() style for column blocks in starter content homepage. fixes [#393](#393). ([#394](#394)) ([71a7bd7](71a7bd7))
* store support token per-user instead of globally ([2b4af08](2b4af08))
* update Site Kit connection check for latest SK version ([6ffd884](6ffd884))
* when preview is waiting vertically align items to the center ([0f2c48a](0f2c48a))
* wpcom  endpoints for stripe activity ([#458](#458)) ([7230ac5](7230ac5))

### Features

* adjust happychat style ([a6d501c](a6d501c))
* **support:** add Happychat ([f483f84](f483f84))
* Add MC4WP to supported plugins. ([68b1476](68b1476))
* add support screen ([#451](#451)) ([c76cb72](c76cb72))
* move proxied-imports ([d6973e3](d6973e3))
* remove tabbed navigation on Donations/Memberships screens, add back buttons. ([20678b7](20678b7))
* whitelist plugin - Password Protected. ([#398](#398)) ([71febf4](71febf4))

### Reverts

* Revert "Handoff Banner: Update style to visually match the rest of the plugin" ([3b9243c](3b9243c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Managed Newspack [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants