Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grid view option to the Dashboard #496

Merged
merged 8 commits into from Mar 31, 2020
Merged

Add grid view option to the Dashboard #496

merged 8 commits into from Mar 31, 2020

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented Mar 23, 2020 •
edited

All Submissions:

Changes proposed in this Pull Request:

Adds 2 icons in the header to change the view of the dashboard: List or Grid.

Kapture 2020-03-30 at 12 42 01

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Go to Newspack > Dashboard. Do you see the 2 icons at the top?
  3. Change the view to Grid
  4. Go to a different page then come back to the Dashboard. Do you still see the Dashboard as a grid?

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jeffersonrabb
Copy link
Contributor

@thomasguillot as of 6e67e9b the layout selection will be persisted in Local Storage.

@thomasguillot thomasguillot added the [Status] Needs Review The issue or pull request needs to be reviewed label Mar 30, 2020
@thomasguillot thomasguillot marked this pull request as ready for review March 30, 2020 11:46
adekbadek
adekbadek approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

assets/wizards/dashboard/index.js Outdated Show resolved Hide resolved
@adekbadek adekbadek added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 31, 2020
@thomasguillot thomasguillot merged commit 03b0646 into master Mar 31, 2020
@thomasguillot thomasguillot deleted the update/dashboard-views branch March 31, 2020 13:56
matticbot pushed a commit that referenced this pull request Apr 1, 2020
@semantic-release-bot
chore(release): 1.4.0 [skip ci]
d7a7b2e 
# [1.4.0](v1.3.0...v1.4.0) (2020-04-01)

### Features

* add grid view option to the dashboard ([#496](#496)) ([03b0646](03b0646))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adekbadek adekbadek adekbadek approved these changes

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thomasguillot @jeffersonrabb @matticbot @adekbadek