Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel Block: Make sure links don't incorrectly pick up custom colours #1778

Merged
merged 1 commit into from Apr 21, 2022

Conversation

laurelfulford
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR tweaks the styles for the post carousel block, to prevent the theme from incorrectly overriding the white links.

Closes #1015

How to test the changes in this Pull Request:

  1. Start with the Newspack default theme.
  2. Add a post carousel block to the editor; make sure the category is also displaying and publish.
  3. Note that the links aren't all white in the editor, and the category has a background on hover on the front-end.
  4. Apply the PR and run npm run build.
  5. Confirm that the links are now all white in the editor and on the front-end, when hovered and visited.
  6. Optionally cycle through the other themes and confirm that the links are white.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@laurelfulford laurelfulford added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 21, 2022
@laurelfulford laurelfulford requested a review from a team as a code owner April 21, 2022 02:22
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 21, 2022
@laurelfulford
Copy link
Contributor Author

Thanks!

@laurelfulford laurelfulford merged commit 88f20e9 into master Apr 21, 2022
@laurelfulford laurelfulford deleted the fix/1015-carousel-link-colours branch April 21, 2022 15:47
matticbot pushed a commit that referenced this pull request May 2, 2022
# [1.58.0-alpha.1](v1.57.2...v1.58.0-alpha.1) (2022-05-02)

### Bug Fixes

* correct margin issue in editor with floated images ([#1781](#1781)) ([cf4e008](cf4e008))
* make sure captions and credits inherit colours ([#1775](#1775)) ([302b2e3](302b2e3))
* make sure links remain white in the carousel block ([#1778](#1778)) ([88f20e9](88f20e9))
* remove unneeded featured image content option ([#1776](#1776)) ([1afddcf](1afddcf))

### Features

* add custom style to subscribe patterns ([#1760](#1760)) ([83a836e](83a836e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.58.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 3, 2022
# [1.58.0](v1.57.2...v1.58.0) (2022-05-03)

### Bug Fixes

* correct margin issue in editor with floated images ([#1781](#1781)) ([cf4e008](cf4e008))
* make sure captions and credits inherit colours ([#1775](#1775)) ([302b2e3](302b2e3))
* make sure links remain white in the carousel block ([#1778](#1778)) ([88f20e9](88f20e9))
* remove unneeded featured image content option ([#1776](#1776)) ([1afddcf](1afddcf))

### Features

* add custom style to subscribe patterns ([#1760](#1760)) ([83a836e](83a836e))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.58.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel Block: Custom colours overriding author link
3 participants