Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build of 1.2.4 on windows 8 fails - cairo.h not found (all good with 1.2.3) #591

Closed
timknip opened this issue Jul 26, 2015 · 5 comments
Closed

Comments

@timknip
Copy link

timknip commented Jul 26, 2015

commit 86d6ec59b7cb0e4ffce47b9cee81a9ce20afcb1e seems to be the culprit.

In GTK 2 cairo.h lives in include/cairo/cairo.h
Hence its not found and the build fails

EDIT: Guess this PR will fix the issue #589

@LinusU
Copy link
Collaborator

LinusU commented Jul 28, 2015

@timknip I'm rather sure that we'll need #589 to fix this, but do you think that you have time to try with 1.2.5? 1.2.4 was broken and didn't work at all.

@timknip
Copy link
Author

timknip commented Jul 29, 2015

@LinusU 1.2.5 fails too... so yeah, #589 for sure is needed.

Canvas.h(19): fatal error C1083: Cannot open include file: 'cairo.h': No such file or directory 

@timknip
Copy link
Author

timknip commented Jul 29, 2015

@LinusU Let me know if you merged the PR... btw: canvas-browserify uses <1.2.4 for now to prevent install problems. As soon as canvas > 1.2.3 builds again, i'll of course update.

@timknip
Copy link
Author

timknip commented Jul 29, 2015

@LinusU Tested 1.2.5 on win8 (x64) with #589 merged.
Seems to work fine. Tests are passing.
node test/server.js is also looking good

@LinusU
Copy link
Collaborator

LinusU commented Aug 3, 2015

Fixed in 1.2.6 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants