Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Details panel is not consistent #1860

Closed
1 task done
vivadavid opened this issue Feb 19, 2024 · 4 comments · Fixed by #2325
Closed
1 task done

The Details panel is not consistent #1860

vivadavid opened this issue Feb 19, 2024 · 4 comments · Fixed by #2325
Assignees
Labels
bug Something isn't working

Comments

@vivadavid
Copy link

Description

The Details panel provides different information depending on whether you access to it through the list of episodes of a podcast or through the playback of the episode.

Step-by-step reproduction instructions

  1. You go to a podcast, scroll down until you find an episode you like and tap on it.
  2. You click on Play to listen to the episode.
  3. The panel is automatically minimized.
  4. You tap to maximize it again.
  5. Now the Details panel contains different information. My main problem is that I can't find an icon to download the episode.

It's happened to me a couple of times: I start listening to an episode from a podcast and, at some point, I want to download it, but I can't unless I go back to the list of episodes of the podcast and find the specific episode I'm currently listening to.

The Details panel should always stay the same. If there's some information that needs to be displayed only when the episode is being played, you could either combine all the information or just create a new panel.

Screenshots or screen recording

The Details panel when accessed through the list of episodes:

details_panel_1

The Details panel when the episode is being played:

details_panel_2

(For some reason, there's light mode in one screen and dark mode in the other one, but the screen modes on my phone don't always work well.)

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

Xiaomi mi 9T Pro, Android 11, Pocket Casts 7.57 (9193).

@vivadavid vivadavid added the bug Something isn't working label Feb 19, 2024
@MiSikora
Copy link
Contributor

MiSikora commented Feb 21, 2024

Can you clarify for me what is the core issue? Is it different design of the screens or is it the fact that you can't download episodes from the player's view? For example, would having a download action in the Now playing section of the player solve your problem?

@vivadavid
Copy link
Author

Hi,

I certainly value consistency: I don't understand how the same panel can look so different. In fact, it seems like a different panel despite the name.

Having said that, my main problem is the absence of a download button. It's happened to me a few times that I was listening to a podcast, I needed to download it and I was unable to do it unless I found again the episode on the list of the podcast.

The insertion of a download button would be extremely useful and time-saving.

@MiSikora
Copy link
Contributor

MiSikora commented Feb 21, 2024

The difference is there because part of the Details tab in the episode is in the Now Playing tab of the player. Those are two different contexts for consuming content.

cc: @david-gonzalez-a8c if you can weigh in on the design issue described here.

The insertion of a download button would be extremely useful and time-saving.

I think the most reasonable solution without changing the design is to have download action as an option in the shelf items.

Added it as an internal feature request. Internal ref: pdjfGa-Ia-p2

@david-gonzalez-a8c
Copy link

The refactoring of the episode and player views so they are more consistent (which I agree would be a good thing) would take a bigger design effort. In the meantime, I don't see a reason why we shouldn't add a "Download" action in the player "More actions" sheet.

I've prepared some quick specs here where you can grab the icon from. I suggest we add it before "Archive" on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants