Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tweaks to the new episode badges #1689

Closed
4 tasks done
david-gonzalez-a8c opened this issue May 2, 2024 · 0 comments
Closed
4 tasks done

UI tweaks to the new episode badges #1689

david-gonzalez-a8c opened this issue May 2, 2024 · 0 comments
Assignees
Milestone

Comments

@david-gonzalez-a8c
Copy link

david-gonzalez-a8c commented May 2, 2024

Description

The new grid looks great!

There are a couple tweaks I'd love to make on the new badges:

  • The border color on the badge doesn't match the background. I think it would looks better if it matches. Can we use the same variable as the background? (I assume is $ui-primary-01)
  • The size of the "only latest episode" badge seems a bit small compared to the specs. We had it at 10px there, but I think we can bump it up to 12px. Let's also please double check the size of the border, which looks a bit thinner too (we have it at 3px in the specs).
  • Not sure if this is related to the changes and I haven't been able to reproduce it, but there was an occasion where after changing the badge to "only latest episode" it showed a badge with a "1" in the style of the "Unfinished episodes" badges, instead of just a circle without a number.

Step-by-step reproduction instructions

  1. Go to Podcasts
  2. Tap on the ellipsis menu
  3. Tap on "Badges"
  4. Select "Unfinished episodes" or "Only latest episode"

Screenshots or screen recording

IMG_82687BC57CAD-1

Did you search for existing bug reports?

  • I have searched for existing bug reports.

Device, Operating system, and Pocket Casts app version

iPhone 12 Pro, version 7.63.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants