Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS feed is not rendered as a RSS feed #13

Closed
dd32 opened this issue Apr 1, 2022 · 1 comment
Closed

RSS feed is not rendered as a RSS feed #13

dd32 opened this issue Apr 1, 2022 · 1 comment

Comments

@dd32
Copy link
Member

dd32 commented Apr 1, 2022

It appears that the RSS feed pushed to other sites, doesn't trigger is_feed() to be truthful:

https://meta.trac.wordpress.org/ticket/5533

The code in the plugin in question uses is_feed():
https://plugins.trac.wordpress.org/browser/wporg-glossary/trunk/includes/class-glossary-handler.php?marks=72#L65

I think this can just be changed to query_posts( "p={$post_id}&feed={$feed_type}" ); maybe?
https://github.com/Automattic/pushpress/blob/trunk/send-ping.php#L43

wp> query_posts( "p=12512" );
...
wp> $wp_query->is_feed();
bool(false)
wp> is_feed();
bool(false)

wp> query_posts( "p=12512&feed=rss2" );
...
wp> $wp_query->is_feed();
bool(true)
wp> is_feed()
bool(true)

I haven't tested this with the plugin yet, and I could update the wporg-glossary plugin to also prevent filtering during cron events, but regardless, ensuring is_feed() returns correctly seems like a worthy change.

Just noting, I've pushed this change onto WordPress.org for testing.

@Krinkle
Copy link

Krinkle commented Apr 19, 2022

I can confirm that the observed issue that has plagued make.wordpress.org feeds throughout the past year, has been resolved for me. (Details at FreshRSS/FreshRSS#4302)

Thank you!

@dd32 dd32 closed this as completed in 710b416 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants