Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style the "Take Course" notice in Learning Mode when not logged in #7242

Closed
donnapep opened this issue Oct 20, 2023 · 0 comments · Fixed by #7264
Closed

Style the "Take Course" notice in Learning Mode when not logged in #7242

donnapep opened this issue Oct 20, 2023 · 0 comments · Fixed by #7264
Assignees
@Imran92
Labels
[Pri] Normal Can wait for the next release [Project] Frontend Improvements [Type] Bug
Milestone
4.19.2

Comments

@donnapep
Copy link
Collaborator

Steps to Reproduce

  1. Activate the Course theme.
  2. Enable Learning Mode.
  3. While logged out, visit the lesson page for a course you are not taking.
  4. See the notice.

What I Expected

The notice to be styled similarly to the other notices (see screenshots). Take course and Sign in buttons to be visible.

What Happened Instead

The notice isn't styled the same as other notices in Learning Mode. For the Course theme, the notice has no buttons. For Astra, the buttons are too tight to the text.

Screenshot / Video

Course Theme - Current

Screenshot 2023-10-20 at 11 22 07 AM

Course Theme - Desired

Screenshot 2023-10-20 at 11 13 10 AM

Astra Theme - Current

Screenshot 2023-10-20 at 11 23 24 AM

Astra Theme - Desired

Screenshot 2023-10-20 at 11 23 15 AM
@donnapep donnapep added this to the 4.19.0 milestone Oct 20, 2023
@donnapep donnapep modified the milestones: 4.19.0, 4.20.0 Oct 31, 2023
@Imran92 Imran92 mentioned this issue Nov 3, 2023
Merged
14 tasks
@Imran92 Imran92 self-assigned this Nov 3, 2023
@Imran92 Imran92 mentioned this issue Nov 3, 2023
Merged
14 tasks
@donnapep donnapep modified the milestones: 4.20.0, 4.19.2 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Imran92 Imran92

Labels
[Pri] Normal Can wait for the next release [Project] Frontend Improvements [Type] Bug
Projects
None yet
Milestone
4.19.2
Development

Successfully merging a pull request may close this issue.

Fix notice style for not logged in users in learning mode Automattic/sensei
2 participants
@donnapep @Imran92