Fixed the failing test where server crashes on disconnect involving connectBuffer #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnectBuffer Source of bug: after connection to nsp '/', the socket's connectBuffer was being deleted. On attempt to reconnect to a different namespace, the connect buffer was deleted and we attempted to push to it. Instead of the deleting the connect buffer, it is now emptied.
rauchg
added a commit
that referenced
this pull request
Jul 16, 2014
…r-crash Fixed the failing test where server crashes on disconnect involving connectBuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source of bug: after connection to nsp '/', the socket's connectBuffer
was being deleted. On attempt to reconnect, we attempted to push to a deleted array.
Instead of the deleting the connect buffer, it is now emptied.