Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase + block themes: comments block #5833

Closed
MaggieCabrera opened this issue Apr 8, 2022 · 7 comments
Closed

Blockbase + block themes: comments block #5833

MaggieCabrera opened this issue Apr 8, 2022 · 7 comments
Assignees
Labels

Comments

@MaggieCabrera
Copy link
Contributor

The new comments block is already in GB, we should start a PR to implement it on Blockbase and see how much CSS we can remove from it. The block will make it to 6.0 so we should update the required version accordingly.

WordPress/gutenberg#40186

This goes for any of the block themes that may have extra CSS just for the comment block too

@jeffikus
Copy link
Contributor

@MaggieCabrera would we need to wait for 6.0 to ship first before shipping updates to the themes, or can we ship in preparation for this?

@MaggieCabrera
Copy link
Contributor Author

We've discussed about breaking changes on Blockbase that require Gutenberg and decided against them for the parent theme (but they are ok for child themes). We want to keep Blockbase working without the plugin, since it's been used as a parent theme for production sites outside our own child themes.

@MaggieCabrera MaggieCabrera changed the title Blockbase: comments block Blockbase + : comments block Apr 25, 2022
@MaggieCabrera MaggieCabrera changed the title Blockbase + : comments block Blockbase + block themes: comments block Apr 25, 2022
@MaggieCabrera
Copy link
Contributor Author

Please note that the Comments form block is not going to make it to 6.0, but it's good that we start opening the PRs in any case.

@MaggieCabrera
Copy link
Contributor Author

More on this: WordPress/gutenberg#40521

@jp-imagines
Copy link

Just noting that this came up in 5279831-zd-woothemes, as the depreciated Post Comments block's "notify by email" checkboxes overlap, and switching to the Comments block resolves that. Informed the user how to update to the newer Comments block, as an eventual switch here won't have affected them since they already made edits to their Single Post template (per p1654700804534859-slack-C029FM1EH).

Markup on 2022-06-08 at 11:30:19

@pbking
Copy link
Contributor

pbking commented Jun 8, 2022

Considering that the comments block isn't in 6.0, and that our aim for Blockbase is to be limited to what features are available in core-sans-gutenberg this change isn't likely there yet.

Do we know when we can expect this comments block to head into Core?

Is there something we can/should to with CSS to address that overlap in the meantime?

That said, I don't think we need to hold any of the child themes to that standard so we can begin to update the rest of those themes.

@MaggieCabrera
Copy link
Contributor Author

Considering that the comments block isn't in 6.0, and that our aim for Blockbase is to be limited to what features are available in core-sans-gutenberg this change isn't likely there yet.

Do we know when we can expect this comments block to head into Core?

Is there something we can/should to with CSS to address that overlap in the meantime?

That said, I don't think we need to hold any of the child themes to that standard so we can begin to update the rest of those themes.

I think the query loop made it, just not the forms block, and we can keep using the legacy one for that. So told me the frontity people during WC, which are the ones leading the Comments block effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants