Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme] Franklin: Live site not reflecting table background color change #6962

Open
hacchism opened this issue Mar 25, 2023 · 1 comment
Open
Labels
[Platform] Atomic [Platform] Simple [Pri] Normal Triaged [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report

Comments

@hacchism
Copy link

Quick summary

When a custom background color is set to tables in the editor with the Franklin theme, it's not applied to live site.

Steps to reproduce

  1. Activate the Franklin theme.
  2. Create a new page and add a table with the Table Block.
  3. Set a custom background color.
  4. Publish the page and check the live page.

What you expected to happen

Custom background color set in editor is applied on the live page.

What actually happened

It shows up with light gray(#f7f7f7) no matter which custom background color is set in editor.

Editor:
Screen Shot on 2023-03-25 at 15:05:35

Live page:
Screen Shot on 2023-03-25 at 15:05:55

Impact

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

For Premium or higher, we can use CSS for a quick fix but no workaround is available for Personal or lower.

table td {
    background-color: #XXXXXX;
}
@hacchism hacchism added [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report labels Mar 25, 2023
@cuemarie
Copy link

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple: Replicated
  • Tested on AT: Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Replicated just as described.

The table block still shows the custom background color, but there are styles on the thead and tbody that override that:

Markup on 2023-03-29 at 17:33:49

table thead th {
  background-color: #f0f0f0;
table td, table tbody th {
  background-color: #f7f7f7;
CevlTG.mov

📌 ACTIONS

  • Assigned to Themes
  • Requested author feedback
  • Added to ‘Bug scrub planning’ project board
  • Transferred to themes repo

@cuemarie cuemarie transferred this issue from Automattic/wp-calypso Mar 30, 2023
@cuemarie cuemarie added this to Needs triage in Bug Scrub Planning via automation Mar 30, 2023
@cuemarie cuemarie changed the title Franklin: Live site not reflecting table background color change [Theme] Franklin: Live site not reflecting table background color change Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Platform] Atomic [Platform] Simple [Pri] Normal Triaged [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report
Projects
Bug Scrub Planning
  
Needs triage
Development

No branches or pull requests

2 participants