Makes dev-env closer to vip go #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjinks
previously approved these changes
Sep 19, 2022
|
|
In what way @WPprodigy ? It does seem to control a lot of places and significantly changes WP behaviour (e.g. no plugin installs) It feels to me that in order to get closer to real platform setup we want this to be true, or? |
|
This constant is being used in codebases to determine if a site is on a live VIP env or if its elsewhere - like a local environment. I don't think it's very clear or true to say a local environment === a vip environment. |
|
Gread points. I removed the setting of |
sjinks
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets some constants and config to behave more closely to VIP go platform.
define( 'FORCE_SSL_ADMIN', true );Solves #267