Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: reblogs #19587

Open
gwwar opened this issue Nov 7, 2017 · 6 comments
Open

Comments: reblogs #19587

gwwar opened this issue Nov 7, 2017 · 6 comments
Labels
[Feature] Comments Comments on posts and the admin screen for managing them. [Status] Stale [Type] Task

Comments

@gwwar
Copy link
Contributor

gwwar commented Nov 7, 2017

We should detect reblogs and style the comment appropriately. Determine if we can identity reblogs without having to parse comment content.

Currently we are applying a red link because the content contains a link.

screen_shot_2017-11-07_at_10 51 32_am_720

I believe we want to omit the red link icon, and use the reblog gridicon instead:
screen shot 2017-11-07 at 2 49 08 pm

cc @drw158 if you had other thoughts

To add a reblog, follow instructions here: https://en.support.wordpress.com/reblogs/

@gwwar gwwar created this issue from a note in Comment Management (m3) Nov 7, 2017
@gwwar gwwar added [Type] Task [Feature] Comments Comments on posts and the admin screen for managing them. labels Nov 7, 2017
@davewhitley
Copy link
Contributor

Sounds good to me!

@Copons Copons self-assigned this Nov 10, 2017
@Copons
Copy link
Contributor

Copons commented Nov 10, 2017

Problem: reblogs are comments of type comment.
Apparently the only thing that could help us recognize them as reblogs is the comment. E.g.

<p>Reblogged this on <a href="https://coponstestpersonal.wordpress.com/2017/11/07/template-comments/" rel="nofollow">Copons Test PERSONAL</a> and commented: </p>
<p>Reblog</p>

In other words, we have no way to reliably know it's a reblog, especially if we consider that "reblog" is a localized string:
Reblogged this on %s is

  • A reblogué ceci sur %s in French.
  • Hat dies auf %s rebloggt in German.

(yes, I know that all these languages contain the word "reblog", but that's not the point 🙂 )

@gwwar
Copy link
Contributor Author

gwwar commented Nov 10, 2017

@drw158 would you be ok with us punting this for now? To more reliably mark these we might want to change the comment type when reblogging.

@gwwar gwwar moved this from m3 to m5 in Comment Management Nov 11, 2017
@davewhitley
Copy link
Contributor

Ok to punt

@Copons Copons removed their assignment Jun 29, 2020
@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Comments Comments on posts and the admin screen for managing them. [Status] Stale [Type] Task
Projects
Comment Management
  
unprioritized backlog
Development

No branches or pull requests

4 participants