-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments: reblogs #19587
Comments
Sounds good to me! |
Problem: reblogs are comments of type
In other words, we have no way to reliably know it's a reblog, especially if we consider that "reblog" is a localized string:
(yes, I know that all these languages contain the word "reblog", but that's not the point 🙂 ) |
@drw158 would you be ok with us punting this for now? To more reliably mark these we might want to change the comment type when reblogging. |
Ok to punt |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
We should detect reblogs and style the comment appropriately. Determine if we can identity reblogs without having to parse comment content.
Currently we are applying a red link because the content contains a link.
I believe we want to omit the red link icon, and use the reblog gridicon instead:
![screen shot 2017-11-07 at 2 49 08 pm](https://user-images.githubusercontent.com/1270189/32522114-e058a43c-c3ca-11e7-94ae-a9667681f02d.png)
cc @drw158 if you had other thoughts
To add a reblog, follow instructions here: https://en.support.wordpress.com/reblogs/
The text was updated successfully, but these errors were encountered: