Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: Menu disappears when Publicize and Like buttons are disabled in Jetpack settings (AT sites) #20102

Closed
julsyd opened this issue Nov 22, 2017 · 7 comments
Assignees
Labels
[Closed] Stale [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. FixTheFlows Jetpack [Pri] Normal [Status] Stale [Type] Bug

Comments

@julsyd
Copy link

julsyd commented Nov 22, 2017

Steps to reproduce

  1. Starting at URL: testing34687.com
  2. Go to WP Admin > Jetpack > Settings > Sharing.
  3. Disable "Automatically share your posts to social networks" and "Allow readers to show their appreciation of your posts by adding a like button to your content".

What I expected

I expected "Sharing" to appear in the Calypso left menu.

What happened instead

"Sharing" is no longer visible in the Calypso left menu. All sharing settings can only be accessed via WP Admin > Jetpack > Settings > Sharing.

Browser / OS version

OS High Sierra 10.13.1
Chrome 62.0.3202.94

Screenshot / Video

JetPack settings: https://cloudup.com/c2JDbEn2GA2
Calypso menu: https://cloudup.com/cbniBz65nUl

Context / Source

Sharing buttons are still active, so users need to be able to easily access those settings from Calypso. Users should also be able to easily enable Publicize and Like buttons via Calypso, as normal, despite those settings being disabled in JetPack. It makes things confusing for users as they don't know the Sharing settings can be accessed via WP Admin, or where to even access them there.

#user-report
#manual-testing

@julsyd julsyd added [Type] Bug Jetpack [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. labels Nov 22, 2017
@beaulebens
Copy link
Member

This is effectively another case of "implicit activation" being required. We should show the UI here regardless (unless force-disabled via code, cc @ebinnion ). Then if the user decides to use any of the features, we can/should activate the appropriate modules behind the scenes.

@johnHackworth johnHackworth changed the title Sharing: Menu disappears when Publicize and Like buttons are disabled in JetPack settings (AT sites) Sharing: Menu disappears when Publicize and Like buttons are disabled in Jetpack settings (AT sites) Mar 2, 2018
@alaczek
Copy link
Contributor

alaczek commented Apr 30, 2019

Since the recent implementation of the nav drawer sharing options now live under Tools > Marketing, and I verified it does not disappear when above options are disabled. There is a difference though.

With "Automatically share your posts to social networks" and "Add Like buttons to your posts and pages" enabled:
image

Disabled:
image

From my testing it looks like the options to enable/disable likes is available in both wp-admin and Calypso settings at all times.

The only difference I'm seeing, is that "Connections" tab is not present in Calypso, when "Automatically share your posts to social networks" is disabled in wp-admin (and it can only be enabled via wp-admin). @juliasydnor would having the "Connections" tab be always present in Calypso be a good fix here?

@julsyd
Copy link
Author

julsyd commented May 1, 2019

would having the "Connections" tab be always present in Calypso be a good fix here?

@alaczek sounds good!

@jancavan
Copy link
Contributor

jancavan commented Jul 3, 2019

This is very confusing. It's hard to tell if these settings are related to each other.

I'm curious why these settings need to be enabled in Jetpack before they are displayed in Calypso? Are we not able to display these settings by default in Calypso? Publicize won't be enabled anyway until the user connects each of their social media accounts. And from my understanding, none of the Sharing buttons will appear too unless they explicitly select which pages they want them to appear on?

Screenshot 2019-07-03 09 52 20

In Calypso, "Connections" and "Sharing buttons" are separate tabs. Enabling the "Like" button is under "Sharing buttons". In Jetpack, enabling the Like button appears to be a separate card by itself and doesn't look to be related to the sharing buttons.

I also noticed a bug where even though I do have "Publicize" and "Sharing buttons" enabled in Jetpack, the "Connections" and "Sharing buttons" tabs are not being displayed. But once I click the "Update" button from the sidebar, then click somewhere on the screen, they randomly show up: https://cloudup.com/ci06M75tzhh

I would just display these settings in Calypso without the need for activation. However, if that isn't possible, as interim fixes to start, we could:

  1. Update the Publicize card heading in Calypso to "Publicize connections" so it matches the card in wp-admin:

Screenshot 2019-07-03 09 39 29

Screenshot 2019-07-03 09 39 46

  1. Combine Sharing and Like toggles in wp-admin since "Configure your sharing buttons" link to "Sharing buttons" in Calypso which contains both settings:

Screenshot 2019-07-03 09 46 03

cc @jeffgolenski @alaczek @juliasydnor

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@cuemarie
Copy link

👋 Hey folks! Since this issue has been inactive for quite some time, KitKat has made the decision to close it.

  • Internal reference, for more on this decision: pdqkMK-14B-p2

If you think this issue warrants another look, here are some next steps!

  1. Report anew: A new report with more current details and steps to replicate may be the best way to renew attention on this issue. Feel free to refer back to this closed issue in your report!
  2. Reopen: If you feel the issue still matches the context/history here, you can also reopen the issue and add fresh logs, screenshots and steps to reproduce.

Thanks for your involvement!

@cuemarie cuemarie closed this as not planned Won't fix, can't repro, duplicate, stale Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Stale [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. FixTheFlows Jetpack [Pri] Normal [Status] Stale [Type] Bug
Projects
None yet
Development

No branches or pull requests

7 participants