Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store - Coupon lookup & selection component #20741

Closed
jameskoster opened this issue Dec 12, 2017 · 7 comments
Closed

Store - Coupon lookup & selection component #20741

jameskoster opened this issue Dec 12, 2017 · 7 comments

Comments

@jameskoster
Copy link
Contributor

For manual order creation (and editing orders to an extent) we need a flow for adding coupons to an order. For stores with lots of promotions remembering the names isn't feasible, so we need a coupon lookup - similar to our product lookup. Here's the design:

coupon-lookup

Note that for now this is only a coupon lookup - not a promo lookup. Whether we'll need that functionality in the future I'm not sure.

Although some coupons can be combined, I feel that is less common behaviour. So for now let's use radios so that coupons can only be selected one at a time. We can revisit the UX later if many people need to lookup and select multiple coupons.

@ryelle
Copy link
Member

ryelle commented Dec 12, 2017

So for now let's use radios so that coupons can only be selected one at a time.

The user can always open the dialog again if they want to add a second coupon, I think it makes sense to leave it at the simpler case, since i think this is a smaller use-case than people adding multiple products (but we can also add tracks to these buttons and see what people are doing).

@ryelle ryelle added this to In Progress in Store on .com: 2017-q4 Dec 12, 2017
@jameskoster
Copy link
Contributor Author

jameskoster commented Dec 13, 2017

The user can always open the dialog again if they want to add a second coupon

Totally.

I suppose we need to think about the UX in the following cases though;

  1. User applies a coupon which cannot be used in conjunction with other coupons
  2. User applies a coupon, then tries to apply another coupon which cannot be used in conjunction with other coupons
  3. User applies a coupon that can only be applied when specific products are in the cart, then removes the product which qualifies that coupon.

For 1. I suppose we should just disable the "Apply coupon" button and reveal a tooltip on hover which explains that they'll need to remove the current coupon if they want to add another.

For 2, I don't think we should hide incompatible coupons - that would be confusing. Let's list them but add a notice explaining that they can't be selected. Like so;

combined

(Notice I updated the copy so it no longer states that incompatible coupons are hidden).

For 3 it would be best to automate this. IE when they remove the product remove the coupon as well and display a notice.

@ryelle
Copy link
Member

ryelle commented Dec 13, 2017

What should the order screen look like once a coupon is added? Is it another line item, or a list of tags like wp-admin? It doesn't have a price on its own, though. We're overlapping into #16662 a bit, but here I'm mostly wondering how the applied coupon(s) would be listed on the order screen, and how a store owner would remove a coupon.

@jameskoster
Copy link
Contributor Author

jameskoster commented Dec 14, 2017

I think the wp-admin approach is fine. Let's reveal the "Coupons" section when a coupon has been added to an order.

When viewing an order you see a comma separated list of coupons which link to the edit coupon screen. When editing an order you can delete the coupons. Like so;

coupon

Coupons can only be applied to (or removed from) orders pending payment, right?

@ryelle
Copy link
Member

ryelle commented Dec 15, 2017

@jameskoster Can we move the coupons above or below the totals table? Discount/Shipping/Total etc are full-width table rows so that the contents line up with the contents above, so there isn't actually space where you've put it on the mockup.

Coupons can only be applied to (or removed from) orders pending payment, right?

That will be the case, yes.

@ryelle
Copy link
Member

ryelle commented Dec 18, 2017

I've tried an approach for listing out the coupons, see #20929

@ryelle ryelle removed this from In Progress in Store on .com: 2017-q4 Jan 4, 2018
@ryelle ryelle added this to In progress in 🛒 Store - Q1 2018 Jan 4, 2018
@ryelle ryelle moved this from In progress to To Do in 🛒 Store - Q1 2018 Jan 5, 2018
@ryelle ryelle removed their assignment Jan 30, 2018
@timmyc timmyc removed this from To Do in 🛒 Store - Q1 2018 Mar 13, 2018
@stale
Copy link

stale bot commented Oct 27, 2018

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Oct 27, 2018
@stale stale bot closed this as completed Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants