Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot insert an images with special characters into a Gallery Block with the Calypso Media modal #29880

Closed
nerdysandy opened this issue Jan 3, 2019 · 2 comments
Closed

Cannot insert an images with special characters into a Gallery Block with the Calypso Media modal #29880

nerdysandy opened this issue Jan 3, 2019 · 2 comments
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal
Milestone
Gutenberg Flow Po...

Comments

@nerdysandy
Copy link
Contributor

Pre-requisite: Upload one image with chinese characters in it (https://sandeepsuppport.files.wordpress.com/2019/01/圖書.jpeg) and one with English.

Steps to reproduce

  1. URL: sandeepatomicsiteblog.com (My test site)
  2. My Site -> Blog Posts: Add.
  3. Click on Gallery block to select it to add gallery to your post.
  4. Use both the images you saved above in the pre-requisite, to add to the Gallery.

What I expected

Both the images would show when added to the Post.

What happened instead

The one with chinese characters in it displays as broken image whole the other one works fine.

Browser / OS version

Mac OS (10.13.6) whatsmybrowser.org/b/BQSKXVZ

Screenshot / Video

https://cloudup.com/c1PbjyFXVIe

Context / Source

1682814-zen
@nerdysandy nerdysandy added [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal [Feature] Media The media screen in Calypso, general media management, or integration with third party media. Gutenberg core and removed Gutenberg core labels Jan 3, 2019
@gwwar gwwar changed the title Gallery Block - Images displayed as broken if they have special character in URL/name. Cannot insert an images with special characters into a Gallery Block with the Calypso Media modal Jan 25, 2019
@gwwar
Copy link
Contributor

gwwar commented Jan 25, 2019

Only reproducible with the Calypso media modal insert. Drop & drop works. All other environments work as expected.

@gwwar gwwar added this to the Gutenberg Flow Polish milestone Jan 25, 2019
@mmtr
Copy link
Member

mmtr commented Mar 12, 2019

No longer reproducible after removing Gutenberg on Calypso in favor of #31196.

@mmtr mmtr closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Normal
Projects
None yet
Milestone
Gutenberg Flow Polish
Development

No branches or pull requests
3 participants
@mmtr @gwwar @nerdysandy