Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout/Tax: Unaligned prices in cart #30748

Open
deBhal opened this issue Feb 13, 2019 · 6 comments
Open

Checkout/Tax: Unaligned prices in cart #30748

deBhal opened this issue Feb 13, 2019 · 6 comments
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Pri] Low [Type] Bug

Comments

@deBhal
Copy link
Contributor

deBhal commented Feb 13, 2019

Steps to reproduce

  1. Make sure there's a plan or domain or something in your cart
  2. Open `http://calypso.localhost:3000/checkout/${SITE}?flags=show-tax&total_tax_display=A$12.34&display_taxes=true&total_cost_display=A$348.34`
  3. Have a look at the text alignment in the cart (Don't worry that they don't add up):

checkout_ julesauspremiumtest _wordpress_com

I think the ideal would be to align prices using both the separator and the currency symbol, e.g.:

A$ 336
A$  12.34
--------
A$ 348.34

Maybe adding the missing cents if one of the other values has them.

We're already going to use a table here, and the lib/format-currency::getCurrencyObject() function will break down the price for us (see cart-item.jsx), so this shouldn't be very hard to do, but we can put it off until the core functionality in place, so I'll mark it low priority.

@deBhal deBhal added [Pri] Low [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. labels Feb 13, 2019
@deBhal deBhal added this to To do in Tax on Checkout (US only) via automation Feb 13, 2019
@davipontesblog
Copy link
Contributor

Moved to Checkout Redesign for triaging.

@michaeldcain
Copy link
Member

Confirmed that this is still an issue with the new Checkout flow. It's pretty low priority, given that you need to start with a zero decimal cart subtotal and a taxable location, and it's not as significant in the new design, but I'll add it to the Shilling backlog.

Screen Shot 2021-02-18 at 1 23 50 PM

To reproduce:

  • add a WPcom zero decimal plan to your cart
  • set your location to a taxable one (ie. 10001)
  • look at the cart summary under the payment method step

@michaeldcain michaeldcain added the [Size] XS Tiny sized issue label Feb 18, 2021
@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@cuemarie
Copy link

Hi @michaeldcain ! Kitkat is working on reviewing issues that have been marked [Status] Stale for a long time, and manually closing them, as part of this project: pdqkMK-14B-p2 .

This issue falls under that category, but I see you've recently filed it within Shilling's backlog board. Do you think this warrants leaving open for Shilling to get to, despite it's stale status and age? Let me know your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Pri] Low [Type] Bug
Projects
No open projects
Development

No branches or pull requests

4 participants