New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout/Tax: Unaligned prices in cart #30748
Comments
Moved to Checkout Redesign for triaging. |
Confirmed that this is still an issue with the new Checkout flow. It's pretty low priority, given that you need to start with a zero decimal cart subtotal and a taxable location, and it's not as significant in the new design, but I'll add it to the Shilling backlog. To reproduce:
|
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
Hi @michaeldcain ! Kitkat is working on reviewing issues that have been marked This issue falls under that category, but I see you've recently filed it within Shilling's backlog board. Do you think this warrants leaving open for Shilling to get to, despite it's stale status and age? Let me know your thoughts! |
Steps to reproduce
`http://calypso.localhost:3000/checkout/${SITE}?flags=show-tax&total_tax_display=A$12.34&display_taxes=true&total_cost_display=A$348.34`
I think the ideal would be to align prices using both the separator and the currency symbol, e.g.:
Maybe adding the missing cents if one of the other values has them.
We're already going to use a table here, and the
lib/format-currency::getCurrencyObject()
function will break down the price for us (seecart-item.jsx
), so this shouldn't be very hard to do, but we can put it off until the core functionality in place, so I'll mark it low priority.The text was updated successfully, but these errors were encountered: