Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Layout for /design #3112

Closed
scruffian opened this issue Feb 5, 2016 · 2 comments
Closed

Framework: Layout for /design #3112

scruffian opened this issue Feb 5, 2016 · 2 comments

Comments

@scruffian
Copy link
Member

In #2964 we removed the specific layout files for logged out users and the oauth screen. There is still a separate layout screen for /design which we should also remove, although this is more complex due to the server side rendering.

This was suggested by @drewblaisdell in #2964.

Pinging @ehg @mcsf @ockham and @seear who may be interested.

@ockham
Copy link
Contributor

ockham commented Feb 5, 2016

The main reason for LayoutLoggedOutDesign really is server-side rendering. Layout, OTOH, still has a large number of dependencies that won't work on the server-side (they were the actual reason we introduced LayoutLoggedOutDesign in the first place). I don't see any way to get rid of that extra layout any time soon, TBH.

@drewblaisdell
Copy link
Contributor

Yeah, I looked into the changes that would be necessary to run Layout in a browserless environment, and they are legion. Using a separate layout component seems like a reasonable solution to this until we can use these dependencies on the server, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants