Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loaders for Calypso Revisions with image sideloading diffs #35850

Open
gwwar opened this issue Aug 28, 2019 · 8 comments
Open

Infinite loaders for Calypso Revisions with image sideloading diffs #35850

gwwar opened this issue Aug 28, 2019 · 8 comments
Labels
Revisions [Status] Stale Triaged To be used when issues have been triaged. [Type] Bug

Comments

@gwwar
Copy link
Contributor

gwwar commented Aug 28, 2019

When creating a new site and picking the Business vertical we may have some initial content added. The images eventually are replaced and uploaded to the site proper.

Navigating to edit those pre-populated pages, and clicking revisions we see the following:
broken

Screen Shot 2019-08-28 at 4 06 20 PM

This happens for both FSE and non FSE page editing flows. Some options here, we can not display these diffs, show the same diffs as wp-admin, or at a minimum at least stop the infinite loaders.

@gwwar gwwar added [Type] Bug [Feature] Headstart Resetting a site to the default content for a theme. Revisions and removed [Feature] Headstart Resetting a site to the default content for a theme. labels Aug 28, 2019
@gwwar
Copy link
Contributor Author

gwwar commented Aug 28, 2019

cc @apeatling on priority

@apeatling
Copy link
Member

So to be clear, the issue is that it creates revisions that are not from user edits?

@gwwar
Copy link
Contributor Author

gwwar commented Aug 28, 2019

@apeatling Right it's from replacing images src values from the hotlinked file asset to a relative site image file.

@vindl vindl added the [Pri] Low label Oct 8, 2019
@ianstewart
Copy link
Contributor

Just confirming that this is still happening. Non-FSE, new user, new site. Multiple revisions that can't be accessed or edited.

infinite-loading-revisions

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@ianstewart
Copy link
Contributor

This is still live.

2021-03-08 14 24 42

To reproduce:

  1. Create a site on WP.com.
  2. Click on a pre-created page in /pages to open page in Editor.
  3. Click on Revisions in sidebar.
  4. See bug.

@jeyip jeyip added the Triaged To be used when issues have been triaged. label Mar 8, 2021
@jeyip
Copy link
Contributor

jeyip commented Mar 8, 2021

I can reproduce the issue following the given the instructions on Firefox, Chrome, Edge, and Safari.

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Revisions [Status] Stale Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

5 participants