New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlapping banners on Android mobile web #37021
Comments
Just from some quick searching it looks like it may be possible to prevent the PWA banner from appearing in Chrome -- this seems like the best option as it doesn't make much sense to promote both a native app and a PWA at the same time, at least given what I know.
— https://developers.google.com/web/updates/2019/05/mini-infobar-update Maybe a developer could look into this and let us know if this is indeed an option? |
Great to know we have more control over how the PWA is promoted! When the PWA banner was added (#26494) the idea was to promote it to e.g. Pixelbook users. If we remove that default PWA banner we probably want to replace it with something targeting those users (who won't see the native app banners), rather than removing it entirely. cc @gravityrail - just a heads up about this issue/discussion. |
@mattmiklic @rachelmcr I'll also follow up on the work we did for these banners mid next week when I've a couple of other things over the line, and see if we have a clear proposal to improve them. |
👍 It sounds like in that Google documentation that that's what's recommended. Though I think Pixelbook users can install Android apps now as well, for what it's worth, so maybe it'd be worth discussing whether the PWA or the native app is what we'd prefer to promote. |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
There are two banners that overlap in Calypso on Android mobile web:
The PWA banner completely hides the “Open in app” and “No thanks” buttons on the app promo banner.
Steps to reproduce
History
->Clear browsing data
(make sure that the option to clearCookies
is ticked) then click theClear Data
button.Browser / OS version / Device
Confirmed on Chrome / Android 8.1.0 / moto e5 play
Screenshot
Left: Overlapping banners
Right: App promo banner with visible buttons after dismissing PWA banner
h/t @theck13 for reporting this for investigation (internal ref: paaHJt-hO-p2)
Context
Related work:
There was some discussion/review of the app promo banners (internal ref: p9OQAC-g7-p2) that led to a proposal that we move those banners to the top of the screen (internal ref: pauD4L-iZ-p2). If we move that proposal forward, it would resolve this issue by having the app promo banners at the top and the PWA banner at the bottom. However, moving the app banners to the top would create a double banner on iOS (app promo banner + iOS system smart banner) — that might require us to take a different approach to any changes to the app promo banners. cc @mattmiklic @osullivanchris
The text was updated successfully, but these errors were encountered: