Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeds: Fix Error Display when Embed Fails #37131

Open
gwwar opened this issue Oct 28, 2019 · 3 comments
Open

Embeds: Fix Error Display when Embed Fails #37131

gwwar opened this issue Oct 28, 2019 · 3 comments
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Bug

Comments

@gwwar
Copy link
Contributor

gwwar commented Oct 28, 2019

When attempting to embed an unsupported URL, we show an empty block instead of the embed URL block with a human readable error.

To reproduce try embedding a Medium post.

Expected Actual
Screen Shot 2019-10-28 at 4 47 15 PM Screen Shot 2019-10-28 at 4 54 48 PM
@gwwar gwwar added [Type] Bug [Goal] Gutenberg Working towards full integration with Gutenberg labels Oct 28, 2019
@carinapilar
Copy link

When trying to embed a video from the FramaTube platform (with the video's URL), it shows the following:

EmbedBlockError

It's just a video, and it loads on the live site, the messaging sounds confusing.

@lancewillett
Copy link
Contributor

From my experience, the fallback should be a plain URL, the same result as "Convert to a link."

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants